Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build against libre2-dev if found #2255

Merged
merged 7 commits into from
Jun 6, 2023
Merged

build against libre2-dev if found #2255

merged 7 commits into from
Jun 6, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 2, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added kind/enhancement New feature or request area/configuration labels Jun 2, 2023
@mmetc mmetc added this to the 1.5.3 milestone Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #2255 (3c2e3b2) into master (3cc6b2c) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2255      +/-   ##
==========================================
+ Coverage   55.62%   55.74%   +0.11%     
==========================================
  Files         182      182              
  Lines       25551    25552       +1     
==========================================
+ Hits        14213    14243      +30     
+ Misses       9779     9749      -30     
- Partials     1559     1560       +1
Flag Coverage Δ
bats 37.39% <100.00%> (+0.12%) ⬆️
unit-linux 54.53% <ø> (-0.04%) ⬇️
unit-windows 50.95% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cwversion/version.go 63.63% <100.00%> (+0.67%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc requested a review from sabban June 2, 2023 12:42
@mmetc mmetc requested a review from blotus June 5, 2023 15:03
@mmetc mmetc merged commit edd0625 into master Jun 6, 2023
@mmetc mmetc deleted the re2 branch June 6, 2023 13:46
mmetc added a commit that referenced this pull request Jun 9, 2023
@mmetc
build against libre2-dev if found (#2255)
089eb92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blotus blotus blotus approved these changes

@sabban sabban Awaiting requested review from sabban

Assignees
No one assigned
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmetc @blotus